fix: jan research blog ogimage
#6282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minh141120
approved these changes
Aug 25, 2025
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 91eb37c in 1 minute and 26 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/src/pages/post/jan-v1-for-research.mdx:8
- Draft comment:
Consider prepending a slash to the relative path (e.g., '/assets/images/general/og-jan-research.jpeg') to ensure correct asset resolution from the site root. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% This is a frontend asset path issue. The comment is suggesting a best practice for asset resolution, but we don't have enough context about the site's asset handling to know if this is actually needed. The rules state not to comment on pure frontend UI or styling changes and to assume the author made UI changes correctly. The comment could be correct that prepending a slash would improve asset resolution. Without seeing the site's asset handling code, I can't be 100% sure this is unnecessary. However, this is clearly a frontend UI/asset path issue, which the rules explicitly state we should not comment on. We should trust that the author knows how their site handles asset paths. Delete this comment as it relates to frontend asset handling, which we are instructed to assume the author has handled correctly.
Workflow ID: wflow_OjSo4QuJ3teZl8py
You can customize 
|
Preview URL: https://9a65d663.docs-9ba.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request makes a small update to the Open Graph image path in the
docs/src/pages/post/jan-v1-for-research.mdxfile to improve asset organization.ogImagevalue to use a relative path:assets/images/general/og-jan-research.jpeginstead of an absolute URL.Fixes Issues
Self Checklist
Important
Update
ogImagepath injan-v1-for-research.mdxto use a relative path for better asset organization.ogImagepath injan-v1-for-research.mdxto use a relative pathassets/images/general/og-jan-research.jpeginstead of an absolute URL.This description was created by
for 91eb37c. You can customize this summary. It will automatically update as commits are pushed.